Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new job for kueue multikueue integration tests #34202

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Introduce new job for kueue multikueue integration tests #34202

merged 1 commit into from
Jan 27, 2025
+30 −0

Conversation

mszadkow
Copy link
Contributor

Relates to Kueue #4040

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mszadkow. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 23, 2025
@mimowo
Copy link
Contributor

mimowo commented Jan 24, 2025

/hold
for kubernetes-sigs/kueue#4042 to merge first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@mszadkow
Copy link
Contributor Author

kubernetes-sigs/kueue#4042

Merged, please /unhold

@mimowo
Copy link
Contributor

mimowo commented Jan 27, 2025

/lgtm
/approve
IIUC there will be a follow up PR in kueue to exclude the multikueue tests from the "main" suite?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, mszadkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2025
@kannon92
Copy link
Contributor

#34202 (comment)

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 522f249 into kubernetes:master Jan 27, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@mszadkow: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kueue-presubmits-main.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits-main.yaml

In response to this:

Relates to Kueue #4040

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mszadkow
Copy link
Contributor Author

/lgtm /approve IIUC there will be a follow up PR in kueue to exclude the multikueue tests from the "main" suite?

correct

@mszadkow mszadkow deleted the feature/add-multikueue-integration-test-job branch January 27, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mszadkow @k8s-ci-robot @mimowo @kannon92